Wireshark-commits: [Wireshark-commits] master 6fd1531: Add a comment explaining why err is volatile
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 03 Feb 2018 21:34:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6fd153181402f897577aebb3943a23c2666c2864
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6fd1531 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a comment explaining why err is volatile.
    
    And also indicate that perhaps the right solution was just to close the
    CID as a false positive, as Coverity doesn't have a deep enough
    understanding of libnl to know that the loop isn't guaranteed to be
    infinite.
    
    Change-Id: Ieb0651c803a5939fb54f2bc68bdf8c5485dafaf2
    Reviewed-on: https://code.wireshark.org/review/25582
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ebb471f   Clean up addition of FT_IPv{4,6} fields.
    adds  6fd1531   Add a comment explaining why err is volatile.


Summary of changes:
 caputils/ws80211_utils.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)