Wireshark-commits: [Wireshark-commits] master d5f52cf: Don't link wiretap plugins with libwireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 03 Feb 2018 21:04:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5f52cfaf51e81db8b268da0b4c572d19b809432
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d5f52cf by Guy Harris (guy@xxxxxxxxxxxx):

    Don't link wiretap plugins with libwireshark.
    
    Make the second argument to add_plugin_library() and install_plugin() be
    a plugin type - currently, either "epan" or "wiretap" - and, based on
    its value, set the subfolder and required libraries in
    add_plugin_library() and the subfolder in install_plugin().  If it's not
    one of the known values, fail.
    
    Change-Id: I556863772c59330d2854fbb4673f544f8359dcd2
    Reviewed-on: https://code.wireshark.org/review/25579
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d8551c4   Handle separate directories for libwireshark and libwiretap plugins.
    adds  d5f52cf   Don't link wiretap plugins with libwireshark.


Summary of changes:
 cmake/modules/WiresharkPlugin.cmake | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)