Wireshark-commits: [Wireshark-commits] master 2d8606b: CIP Motion: Support Format Revision 3
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 03 Feb 2018 04:19:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d8606b584025bb80c3935aa3ecc57b512c61360
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d8606b by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Support Format Revision 3
    
    See Volume 9, version 1.2, sections "6-2.7.1.1" and "7-1.1"
    1. Pass Connection Point from FwdOpen to Motion dissector, since that is now needed to parse I/O payload.
    2. Move Run/Idle Header function to CIP dissector, since it's a CIP feature, not ENIP.
    3. Add a protocol so that Format Revision 3 can be dissected without the Forward Open in the capture.
    4. Minor: Highlight more bytes in some EPATH parsing.
    5. Minor: Renaming some things to match spec wording.
    
    Change-Id: I93626a6492be2675206d38c04fa1c7ce534c04ca
    Reviewed-on: https://code.wireshark.org/review/25570
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a4bb6c2   Make a deep copy of our filename in RecentFileStatus.
    adds  2d8606b   CIP Motion: Support Format Revision 3


Summary of changes:
 epan/dissectors/packet-cip.c       | 47 ++++++++++++++++++++++++++++++--
 epan/dissectors/packet-cip.h       |  3 ++
 epan/dissectors/packet-cipmotion.c | 56 +++++++++++++++++++++++++++-----------
 epan/dissectors/packet-enip.c      | 55 +++++--------------------------------
 epan/dissectors/packet-enip.h      |  1 +
 5 files changed, 95 insertions(+), 67 deletions(-)