Wireshark-commits: [Wireshark-commits] master 3f71262: netlink (sock_diag): Fix Dead Store (Dead as
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 13 Apr 2017 20:41:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f71262bb1e7dd0b0fe062b6ec20f2cb2291255a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3f71262 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    netlink (sock_diag): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    
    The payload dissection should start after the header, so do not reset offset.
    
    Fixes: v2.3.0rc0-3039-g92ebd63892 ("netlink: let subdissectors handle the netlink header")
    Change-Id: I6bdfdd967bc56cb99c07f4f151ef96592e18a508
    Reviewed-on: https://code.wireshark.org/review/21057
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0c597f1   [GSM MAP] Update to 3GPP TS 29.002 V14.3.0 (2017-03).
    adds  3f71262   netlink (sock_diag): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang


Summary of changes:
 epan/dissectors/packet-netlink-sock_diag.c |    2 --
 1 file changed, 2 deletions(-)