Wireshark-commits: [Wireshark-commits] master 62b3424: Pull the error-reporting code for preference
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 9 Apr 2017 03:03:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62b342443ddf2e5089c9cbaf137dc6a81b0b4678
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

62b3424 by Guy Harris (guy@xxxxxxxxxxxx):

    Pull the error-reporting code for preference files into read_prefs().
    
    No need to duplicate it in N different programs.
    
    Update comments while we're at it.
    
    Change-Id: I3096cbe5448a19363eff6303bdd54e522dae9336
    Reviewed-on: https://code.wireshark.org/review/20973
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f0a24be   Have vwarning_alert_box() pop up a warning, not an error.
    adds  62b3424   Pull the error-reporting code for preference files into read_prefs().


Summary of changes:
 dftest.c                        |   30 +-----------------------
 epan/prefs.c                    |   49 ++++++++++++++-------------------------
 epan/prefs.h                    |   15 +++---------
 rawshark.c                      |   28 +---------------------
 sharkd.c                        |   28 +---------------------
 tfshark.c                       |   31 ++-----------------------
 tshark.c                        |   31 ++-----------------------
 ui/gtk/main.c                   |   33 +-------------------------
 ui/qt/wireshark_application.cpp |   33 +-------------------------
 9 files changed, 29 insertions(+), 249 deletions(-)