Wireshark-commits: [Wireshark-commits] master-2.2 382c135: Bluetooth: HCI_CMD: Fix master-slave rol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Apr 2017 04:24:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=382c135519428aa27af7ad27598809dc6d064e68
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

382c135 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: HCI_CMD: Fix master-slave role
    
    Initiator is always master. Only Role switch event may change it.
    Improve "Accept Connection Request" to avoid users confusion
    by using new specification description:
    0x00 Become the Master for this connection. The LM will perform the role switch.
    0x01 Remain the Slave for this connection. The LM will NOT perform the role switch.
    
    Field "Role" is now splitted from: "bthci_cmd.role"
    and it name is "bthci_cmd.acr.role".
    
    Change-Id: I98e3641b9ba9d2fd6c97808e4772beb4265018fd
    Reviewed-on: https://code.wireshark.org/review/20894
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxxxxxx>
    (cherry picked from commit 76edea174f808785cca55033cb3c2ebfbf149e6a)
    Reviewed-on: https://code.wireshark.org/review/20919
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bdb5385   WASSP: replace a DISSECTOR_ASSERT() by an expert info
    adds  382c135   Bluetooth: HCI_CMD: Fix master-slave role


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |   23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)