Wireshark · Wireshark-commits: [Wireshark-commits] master fb97e82: Distinguish between the two flavors of ITU-T AFIs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb97e82cbe1f177034e8129c9bb48f5b30270003
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb97e82 by Guy Harris (guy@xxxxxxxxxxxx):

    Distinguish between the two flavors of ITU-T AFIs.
    
    As ISO 8348/X.213 Annex A says:
    
    A.5.2.1.2 Format and allocation of the IDI
    
    A specific combination of IDI format and DSP abstract syntax is
    associated with each allocated AFI value, as summarized for use in
    individual addresses in Table A.4 (the corresponding AFI values for use
    in group addresses is found via Table A.2).  Two AFI values are
    associated with each combination that involves a variable-length IDI
    format.  In each case, both of the AFI values identify the same
    combination of IDI format and DSP abstract syntax.  The numerically
    lower AFI value is used when the first significant digit in the IDI is
    non-zero.  The numerically greater AFI value is used when the first
    significant digit in the IDI is zero.
    
    and A.5.3 talks further about this.
    
    Change-Id: I3fdad04064451b3c891731dc8f107bc57586eb84
    Reviewed-on: https://code.wireshark.org/review/20802
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0ea51ad   Qt: Fix uninitialized memory access in val_units_
    adds  fb97e82   Distinguish between the two flavors of ITU-T AFIs.


Summary of changes:
 epan/dissectors/packet-arp.c  |   10 +++---
 epan/dissectors/packet-isup.c |   68 ++++++++++++++++++++---------------------
 epan/osi-utils.h              |   65 ++++++++++++++++++++-------------------
 3 files changed, 72 insertions(+), 71 deletions(-)