Wireshark-commits: [Wireshark-commits] master 038679c: ssl-utils: fix a couple of uninitialized var
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 Mar 2017 10:56:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=038679c6531b763a8c11e157f962d44f61f08b21
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

038679c by Chema Gonzalez (chemag@xxxxxxxxx):

    ssl-utils: fix a couple of uninitialized variables
    
    Fixed these (false-positive) warnings:
    
        epan/dissectors/packet-ssl-utils.c:4149:30: error: 'mac_frag' may be used uninitialized in this function [-Werror=maybe-uninitialized]
        epan/dissectors/packet-ssl-utils.c:4149:30: error: 'mac_fraglen' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             else if(tls_check_mac(decoder,ct,TLSV1_VERSION,mac_frag,mac_fraglen,mac)>= 0) {
    
    Change-Id: I282d5d60d96953858844deeaaf2069ffed3fabca
    Reviewed-on: https://code.wireshark.org/review/20793
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  732d54e   pcapng: Align code name and hf name.
    adds  038679c   ssl-utils: fix a couple of uninitialized variables


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)