Wireshark · Wireshark-commits: [Wireshark-commits] master 1bea950: Add bounds checks for references to outhdr_values.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1bea950b7a7934fe7bed7719a0ed99321785f7d6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1bea950 by Guy Harris (guy@xxxxxxxxxxxx):

    Add bounds checks for references to outhdr_values.
    
    Don't run past the end of the outhdr_values array.
    
    While we're at it, don't make it a global array - it doesn't need to be
    global, as its values don't persist from invocation to invocation, and
    this would allow use of this routine in multiple threads in parallel.
    (Yes, we have other global variables that don't maintain state, but we
    should get rid of that, too.)
    
    Change-Id: I7ceed3c9ba6356eddb7d52472e9d53dd08f90029
    Reviewed-on: https://code.wireshark.org/review/20770
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  616bbce   packet-nstrace.c: Ensure value_strings end with {0, NULL}
    adds  1bea950   Add bounds checks for references to outhdr_values.


Summary of changes:
 epan/dissectors/packet-catapult-dct2000.c |  118 ++++++++++++++++++++---------
 1 file changed, 81 insertions(+), 37 deletions(-)