Wireshark-commits: [Wireshark-commits] master 2f324e7: randpkt_core: Fix a handful of warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Mar 2017 13:42:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f324e770f0fd58065b9e80d878fd3536897ea81
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2f324e7 by Michael Mann (mmann78@xxxxxxxxxxxx):

    randpkt_core: Fix a handful of warnings
    
    1. randpkt_core.c(559): warning C6262: Function uses '65596' bytes of stack:  exceeds /analyze:stacksize '16384'.  Consider moving some data to heap.
    2. randpkt_core.c(615): warning C6386: Buffer overrun while writing to 'buffer':  the writable size is '65536' bytes, but '-1' bytes might be written.
    
    Change-Id: I0f3bcd19b49d6c8cde0d2ad9f745b14f5462a708
    Reviewed-on: https://code.wireshark.org/review/20763
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6b929ab   Don't wire in 262144, use WTAP_MAX_PACKET_SIZE.
    adds  2f324e7   randpkt_core: Fix a handful of warnings


Summary of changes:
 randpkt_core/randpkt_core.c |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)