Wireshark-commits: [Wireshark-commits] master 721182b: Qt: fix closing editor in capture interfaces
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Mar 2017 05:10:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=721182b09ba7212e6c4c2c182d67fb8762a5919d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

721182b by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix closing editor in capture interfaces dialog
    
    Whenever (every second) the points list is updated, a dataChanged signal
    is emitted and Qt decides to close all editors. Workaround this issue by
    disabling the dataChanged signal. (Alternatively, we could change the
    list into a pointer-to-list again.)
    
    Change-Id: Ie06d118d011a72f5be5608c2324ca2715a3f97c7
    Fixes: v2.3.0rc0-2014-gf8dc2346df ("Qt: fix memleak of PointList in interface statistics")
    Reviewed-on: https://code.wireshark.org/review/20530
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e1b14fb   text_import: the maximum frame length should be WTAP_MAX_PACKET_SIZE
    adds  721182b   Qt: fix closing editor in capture interfaces dialog


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)