Wireshark-commits: [Wireshark-commits] master a673056: Add ENC_TIME_TIMEVAL and use it for gsmtap.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Mar 2017 04:38:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6730565f8569b0b8dafc8aebad120c5b66cf3cb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a673056 by Guy Harris (guy@xxxxxxxxxxxx):

    Add ENC_TIME_TIMEVAL and use it for gsmtap.
    
    From a look at the libosmocom code, time stamps in
    GSMTAP_TYPE_OSMOCORE_LOG messages appear to be UN*X struct timevals with
    a 4-byte tv_sec, not anything NTP-like with the fraction-of-a-second
    part in units of 1/2^32s of a second.
    
    Add ENC_TIME_TIMEVAL to handle time stamps like that, and use it rather
    than ENC_TIME_NTP_BASE_ZERO.
    
    Change-Id: Ia1511527ee292fb7725b2a64c0af16d23ff10a6d
    Reviewed-on: https://code.wireshark.org/review/20710
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6c374a2   profinet (pn-rt): fix 'pn_rt.ds_redundancy' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT8
    adds  a673056   Add ENC_TIME_TIMEVAL and use it for gsmtap.


Summary of changes:
 epan/dissectors/packet-gsmtap_log.c |    2 +-
 epan/proto.c                        |   61 +++++++++++++++++++++++------------
 epan/proto.h                        |   38 +++++++++++++++++++---
 3 files changed, 74 insertions(+), 27 deletions(-)