Wireshark-commits: [Wireshark-commits] master b4bc6c7: Qt: refactor Voip Calls Dialog into Model/Vi
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4bc6c72c79fa121753cf94ae179ea73f1e911dd
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
b4bc6c7 by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: refactor Voip Calls Dialog into Model/View
Functional improvements:
- "Time of day" option is now propagated to the CSV/YAML export.
- The sorting order is preserved in the CSV/YAML export.
Other changes:
- Convert column name identifiers to enum.
- CSV output will now always be quoted (previously numbers like packet
count were not quoted, but since CSV has no numeric type it should
be OK to add quotes). Side-effect of model design decision.
- Instead of clearing the widgets and re-adding all calls, now it will
add new calls to the model. Not tested with a live capture, if the
column data can change, maybe a dataChanged signal is needed.
Due to this patch, it should be easier to add a filter for finding calls
easier (e.g. by From, IP, etc.).
Note: extra QList is used in the model to ensure a O(1) lookup of calls
(rather than O(n) for GQueue).
Change-Id: Ie08462aae038d9c3daf1cc7a152b948724689017
Reviewed-on: https://code.wireshark.org/review/20084
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from bff7469 MAC LTE: upgrade dissector to v13.5.0
adds b4bc6c7 Qt: refactor Voip Calls Dialog into Model/View
Summary of changes:
ui/qt/CMakeLists.txt | 2 +
ui/qt/Makefile.am | 2 +
ui/qt/voip_calls_dialog.cpp | 274 +++++++--------------------------------
ui/qt/voip_calls_dialog.h | 12 +-
ui/qt/voip_calls_dialog.ui | 52 +-------
ui/qt/voip_calls_info_model.cpp | 246 +++++++++++++++++++++++++++++++++++
ui/qt/voip_calls_info_model.h | 96 ++++++++++++++
7 files changed, 399 insertions(+), 285 deletions(-)
create mode 100644 ui/qt/voip_calls_info_model.cpp
create mode 100644 ui/qt/voip_calls_info_model.h
