Wireshark-commits: [Wireshark-commits] master 9e35c0b: Fix QT UI bugs in RTP dialogs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 Mar 2017 11:53:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9e35c0bc8b667b79d36c1ce9d16da3228cf5f3c8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9e35c0b by Erik de Jong (erikdejong@xxxxxxxxx):

    Fix QT UI bugs in RTP dialogs
    
    - RTP analysis and player dialogs are modal whereas they were not modal in GTK
    UI
    Only fixed calling up the RTP analysis window being modal when called from the
    RTP streams dialog as it is modeless when called from the menu in the main
    window with a stream packet selected.
    
    - Action 'Next problem packet' triggers an infinite loop when there are no
    'problem packets' and first packet is selected when calling the action.
    
    - Crosshairs not implemented in RTP player/crosshairs context menu item not
    working.
    Context menu item commented out.
    
    bug: 13500
    Change-Id: I0ba954f895b85605462c316e4426280ec4d437b2
    Reviewed-on: https://code.wireshark.org/review/20660
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  50a30c1   [Diameter] Update with AVPs from TS 29.273 V14.2.2
    adds  9e35c0b   Fix QT UI bugs in RTP dialogs


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp |    3 ++-
 ui/qt/rtp_player_dialog.cpp   |    2 +-
 ui/qt/rtp_stream_dialog.cpp   |    6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)