Wireshark-commits: [Wireshark-commits] master 40a5fb5: Restore interface selection after interface
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Mar 2017 05:03:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=40a5fb567a9bd1bb02d38ca33efe64392230d27d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

40a5fb5 by Peter Wu (peter@xxxxxxxxxxxxx):

    Restore interface selection after interface refresh
    
    Remember which interfaces were selected for the next capture and restore
    the selection (note that only active capture devices are stored in
    "ifaces", so simply querying that list does not work).
    
    The original change tried to fix duplicate devices (which were added
    from "ifaces" to "all_ifaces") by clearing "ifaces", this patch tries to
    fix that by ignoring all non-PIPE devices while preserving "ifaces".
    
    Now after refreshing the interfaces list in Qt, the selection in the
    Manage Interfaces dialog is preserved. Removal of the bluetooth0
    interface+refresh does hide the interface. Read+refresh does add the
    interface (and preserve the selected state).
    
    Change-Id: I26a78982f0327c835dc96da9c813e38f31d6cd3d
    Fixes: v1.99.0-rc1-879-g55733ea170 ("fix scan_local_interfaces()")
    Reviewed-on: https://code.wireshark.org/review/20477
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1f5c304   Localize decimal point on time formatted columns.
    adds  40a5fb5   Restore interface selection after interface refresh


Summary of changes:
 ui/iface_lists.c |   71 ++++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 50 insertions(+), 21 deletions(-)