Wireshark-commits: [Wireshark-commits] master c258b6b: ftypes: move get_value_uinteger into the uni
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Mar 2017 01:29:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c258b6b0564f3ef211615f8f19d9067a9364bfe6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c258b6b by Martin Kaiser (wireshark@xxxxxxxxx):

    ftypes: move get_value_uinteger into the union
    
    Delete get_value_uinteger from struct _ftype_t, make it
    part of the get_value union.
    
    Change-Id: I4a6c8341676c442e2bf8ae3b8f771b72161d133c
    Reviewed-on: https://code.wireshark.org/review/20640
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  01b460f   proto(.c): remove unused check and fix indent..
    adds  c258b6b   ftypes: move get_value_uinteger into the union


Summary of changes:
 epan/ftypes/ftype-bytes.c            |    9 ---------
 epan/ftypes/ftype-double.c           |    2 --
 epan/ftypes/ftype-guid.c             |    1 -
 epan/ftypes/ftype-ieee-11073-float.c |    6 ++----
 epan/ftypes/ftype-integer.c          |   35 +++++++---------------------------
 epan/ftypes/ftype-ipv4.c             |    1 -
 epan/ftypes/ftype-ipv6.c             |    1 -
 epan/ftypes/ftype-none.c             |    1 -
 epan/ftypes/ftype-pcre.c             |    1 -
 epan/ftypes/ftype-protocol.c         |    1 -
 epan/ftypes/ftype-string.c           |    4 ----
 epan/ftypes/ftype-time.c             |    2 --
 epan/ftypes/ftypes-int.h             |    2 +-
 epan/ftypes/ftypes.c                 |   13 +++++++++++--
 14 files changed, 21 insertions(+), 58 deletions(-)