Wireshark-commits: [Wireshark-commits] master-2.2 f0cab9f: MySQL: Bugfix state handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Mar 2017 20:44:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0cab9f7a9056dc0977f2defe5c9c07e7669bc52
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f0cab9f by Michael Mann (mmann78@xxxxxxxxxxxx):

    MySQL: Bugfix state handling
    
    A "conversation" is created for MySQL to store "conversation data" including
    current state.  The problem is that it's updated every time a packet is dissected
    so depending on how packets are viewed, dissection may change.
    Fix that by only allowing conversation state to be set on first pass and have
    the state cached with each individual pdu, keyed by tvb_raw_offset() (the key
    when you have multiple pdus in a TCP packet).
    
    Change-Id: I2c7e38be63501360d709210a509aa0dfa482bfd4
    Reviewed-on: https://code.wireshark.org/review/20600
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit a65c0c457668d7524dffefb17cc4e69a77a29f3c)
    Reviewed-on: https://code.wireshark.org/review/20630
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8c9271f   [Automatic update for 2017-03-19]
    adds  f0cab9f   MySQL: Bugfix state handling


Summary of changes:
 epan/dissectors/packet-mysql.c |  150 ++++++++++++++++++++--------------------
 1 file changed, 74 insertions(+), 76 deletions(-)