Wireshark-commits: [Wireshark-commits] master 9a81d2e: Fix: UA3G read past end of tvb + NOE key des
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Mar 2017 20:41:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a81d2ec3764f33a2525c66d784e24f00a852916
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9a81d2e by erikdejong (erikdejong@xxxxxxxxx):

    Fix: UA3G read past end of tvb + NOE key descriptions
    
    packet-ua3g.c:
    Start tone device routing packet causes exception because it adds a subtree with
    length 6 where it should be 3. Changed 6 to 3.
    
    packet-noe.c:
    Key description is incomplete because buffer reserved is only 10 bytes long and
    key descriptions are up to 23 bytes long. Changed buffer length to 24.
    
    Bug: 13502
    Change-Id: I8212d23c650efd341e87f766a80a887ef82f4b0b
    Reviewed-on: https://code.wireshark.org/review/20633
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0fdbaa4   Make GTK compile with HAVE_PCAP_REMOTE on macOS with clang-800.0.42.1.
    adds  9a81d2e   Fix: UA3G read past end of tvb + NOE key descriptions


Summary of changes:
 epan/dissectors/packet-noe.c  |    8 ++++----
 epan/dissectors/packet-ua3g.c |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)