Wireshark-commits: [Wireshark-commits] master 74e793e: ftypes: create a get_value union, move get_v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Mar 2017 12:09:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74e793e8bac3013f0474fdf398608ba24506307c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

74e793e by Martin Kaiser (wireshark@xxxxxxxxx):

    ftypes: create a get_value union, move get_value_floating into the union
    
    Change-Id: I6bbaf6a7c8a3124e5eab7a7b97c6be082fe8beff
    Reviewed-on: https://code.wireshark.org/review/20611
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fd9a595   ICMP: display C-Type when unknown object in extension
    adds  74e793e   ftypes: create a get_value union, move get_value_floating into the union


Summary of changes:
 epan/ftypes/ftype-bytes.c            |   27 +++++----------
 epan/ftypes/ftype-double.c           |    4 +--
 epan/ftypes/ftype-guid.c             |    3 +-
 epan/ftypes/ftype-ieee-11073-float.c |    6 ++--
 epan/ftypes/ftype-integer.c          |   63 ++++++++++++----------------------
 epan/ftypes/ftype-ipv4.c             |    3 +-
 epan/ftypes/ftype-ipv6.c             |    3 +-
 epan/ftypes/ftype-none.c             |    3 +-
 epan/ftypes/ftype-pcre.c             |    3 +-
 epan/ftypes/ftype-protocol.c         |    3 +-
 epan/ftypes/ftype-string.c           |   12 +++----
 epan/ftypes/ftype-time.c             |    6 ++--
 epan/ftypes/ftypes-int.h             |    5 ++-
 epan/ftypes/ftypes.c                 |    6 ++--
 14 files changed, 54 insertions(+), 93 deletions(-)