Wireshark-commits: [Wireshark-commits] master c811288: RNSAP: Call right RRC dissectors for payload
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Mar 2017 11:21:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8112886a7020b14e97ab4c8ccbfe3a36db29930
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c811288 by S. Shapira (sswsdev@xxxxxxxxx):

    RNSAP: Call right RRC dissectors for payload.
    
    According to TS 25.423 both 'Uplink Signaling Transfer' and 'Downlink Signalling Transfer' carry CCCH messages.
    Hence the RRC-UL-CCCH and RRC-DL-CCCH dissectors should be called for the 'L3 Information' fields in these messages (respectively)
    
    Change-Id: Ief2aab77d2851746e6374729eaf8a0a5b115d7d7
    Reviewed-on: https://code.wireshark.org/review/20560
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  0d5d859   [proto.h] Make proto_tree_add_split_bits_item_ret_val() usable from plugins.
    adds  c811288   RNSAP: Call right RRC dissectors for payload.


Summary of changes:
 epan/dissectors/asn1/rnsap/packet-rnsap-template.c |    6 +++--
 epan/dissectors/asn1/rnsap/rnsap.cnf               |    7 +++++-
 epan/dissectors/packet-rnsap.c                     |   25 +++++++++++++-------
 3 files changed, 26 insertions(+), 12 deletions(-)