Wireshark-commits: [Wireshark-commits] master 98558fd: Fix buffer overrun in try_bytesprefix_to_str
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Mar 2017 21:47:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=98558fd81cad9d578ea5085fe8465334e4b266fd
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

98558fd by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix buffer overrun in try_bytesprefix_to_str
    
    bytes_string list contains a list of prefixes to match, not the other
    way round (matching prefixes in the list).
    
    Bug: 13479
    Change-Id: Ie625dc5db30bd55158d688a0101f35d0bf6906af
    Fixes: v2.3.0rc0-2644-g540b555729 ("Introduce "bytes_string" type, similar to "value_string"")
    Reviewed-on: https://code.wireshark.org/review/20532
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f1d0533   Lua: Base must be base.DEC or base.UNIT_STRING for signed integer
    adds  98558fd   Fix buffer overrun in try_bytesprefix_to_str


Summary of changes:
 epan/value_string.c |   13 +++++++------
 epan/value_string.h |    4 ++--
 2 files changed, 9 insertions(+), 8 deletions(-)