Wireshark-commits: [Wireshark-commits] master fe285c6: Replace aes.c and des.c by Libgcrypt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Mar 2017 02:55:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fe285c640b6279fdb9920bb79b0494ac87cb0e32
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fe285c6 by erikdejong (erikdejong@xxxxxxxxx):

    Replace aes.c and des.c by Libgcrypt
    
    Follow-up of https://code.wireshark.org/review/20095
    
    Rewritten functions:
    - crypt_des_ecb
    
    crypt_des_ecb verified against previous crypt_des_ecb implementation with
    4294967295 random keys and input buffers from /dev/random as I cannot find a
    suitable pcap which uses DES
    
    Change-Id: I21ec2572451e0ded4299ffadd8dd687817bc6318
    Reviewed-on: https://code.wireshark.org/review/20429
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  9e0251f   io_graph_item: fix false positive array subscript is above array bounds [-Werror=array-bounds]
    adds  fe285c6   Replace aes.c and des.c by Libgcrypt


Summary of changes:
 debian/libwsutil0.symbols                |    8 +-
 epan/dissectors/packet-dcerpc-netlogon.c |    5 +-
 epan/dissectors/packet-dof.c             |  139 +--
 epan/dissectors/packet-ntlmssp.c         |   32 +-
 wsutil/CMakeLists.txt                    |    2 -
 wsutil/Makefile.am                       |    4 -
 wsutil/aes.c                             | 1365 ------------------------------
 wsutil/aes.h                             |  107 ---
 wsutil/des.c                             |  321 -------
 wsutil/des.h                             |   32 -
 wsutil/wsgcrypt.c                        |   28 +
 wsutil/wsgcrypt.h                        |    5 +
 12 files changed, 121 insertions(+), 1927 deletions(-)
 delete mode 100644 wsutil/aes.c
 delete mode 100644 wsutil/aes.h
 delete mode 100644 wsutil/des.c
 delete mode 100644 wsutil/des.h