Wireshark-commits: [Wireshark-commits] master 3bcda66: ftypes: move set_value_string into the union
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Mar 2017 02:35:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3bcda66971e7eff1bca5155207cb035e185dc6d0
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3bcda66 by Martin Kaiser (wireshark@xxxxxxxxx):

    ftypes: move set_value_string into the union
    
    Delete set_value_string from struct _ftype_t, make it part of the
    set_value union.
    
    Change-Id: Ia3a57245330ed0d158c8c3e4552ec5d80752fe0f
    Reviewed-on: https://code.wireshark.org/review/20474
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e003908   RTP streams dialog: Fix find reverse button
    adds  3bcda66   ftypes: move set_value_string into the union


Summary of changes:
 epan/ftypes/ftype-bytes.c            |    9 ---------
 epan/ftypes/ftype-double.c           |    2 --
 epan/ftypes/ftype-guid.c             |    1 -
 epan/ftypes/ftype-ieee-11073-float.c |    2 --
 epan/ftypes/ftype-integer.c          |   21 ---------------------
 epan/ftypes/ftype-ipv4.c             |    1 -
 epan/ftypes/ftype-ipv6.c             |    1 -
 epan/ftypes/ftype-none.c             |    1 -
 epan/ftypes/ftype-pcre.c             |    3 +--
 epan/ftypes/ftype-protocol.c         |    1 -
 epan/ftypes/ftype-string.c           |   12 ++++--------
 epan/ftypes/ftype-time.c             |    2 --
 epan/ftypes/ftypes-int.h             |    2 +-
 epan/ftypes/ftypes.c                 |    7 +++++--
 14 files changed, 11 insertions(+), 54 deletions(-)