Wireshark-commits: [Wireshark-commits] master da78a59: ftypes: move set_value_bytes into the union
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Mar 2017 14:36:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da78a59744619b2b4e082eb6aa42a1e5b22628ce
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

da78a59 by Martin Kaiser (wireshark@xxxxxxxxx):

    ftypes: move set_value_bytes into the union
    
    Delete set_value_bytes from struct _ftype_t, make it part of the
    set_value union.
    
    Change-Id: I3ee6a9f68b269ee083794947816e13ea6c1b9d29
    Reviewed-on: https://code.wireshark.org/review/20440
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  af8361a   http: Check for valid tcpinfo pointer
    adds  da78a59   ftypes: move set_value_bytes into the union


Summary of changes:
 epan/ftypes/ftype-bytes.c            |   17 ++++-------------
 epan/ftypes/ftype-double.c           |    2 --
 epan/ftypes/ftype-guid.c             |    1 -
 epan/ftypes/ftype-ieee-11073-float.c |    2 --
 epan/ftypes/ftype-integer.c          |   21 ---------------------
 epan/ftypes/ftype-ipv4.c             |    1 -
 epan/ftypes/ftype-ipv6.c             |    3 +--
 epan/ftypes/ftype-none.c             |    1 -
 epan/ftypes/ftype-pcre.c             |    1 -
 epan/ftypes/ftype-protocol.c         |    1 -
 epan/ftypes/ftype-string.c           |    4 ----
 epan/ftypes/ftype-time.c             |    2 --
 epan/ftypes/ftypes-int.h             |    2 +-
 epan/ftypes/ftypes.c                 |    9 +++++++--
 14 files changed, 13 insertions(+), 54 deletions(-)