Wireshark-commits: [Wireshark-commits] master 44e270c: lua: improve FileHandler:[seek_]read behavio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Mar 2017 05:39:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44e270cbd6c6eeea7d86e65970e9837925581ca6
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

44e270c by Peter Wu (peter@xxxxxxxxxxxxx):

    lua: improve FileHandler:[seek_]read behavior and documentation
    
    WSLUA documents FileHandler:read as returning a boolean or integer.
    Ignore strings, do not treat strings as number even if it is possible.
    
    Remove undocumented feature of FileHandler:seek_read that used returned
    strings as the frame data. Use FrameInfo:read_data instead. This avoids
    interpreting numbers as data which caused surprising behavior when
    combining with FileHandler:read.
    
    Documentation has been improved to document the return value, this is
    consistent with the documentation in the WSLUA tests.
    
    Change-Id: I31f74ec33ff0e43c90d83c1904af43801886cfa1
    Reviewed-on: https://code.wireshark.org/review/19366
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cec782c   androiddump: Add ignore log-buffer and custom-options for logcat-text
    adds  44e270c   lua: improve FileHandler:[seek_]read behavior and documentation


Summary of changes:
 epan/wslua/wslua_file_handler.c |   49 +++++++++++++++++++++++++++++----------
 1 file changed, 37 insertions(+), 12 deletions(-)