Wireshark-commits: [Wireshark-commits] lts-1.12.1 f2edf44: Report an error for too-short packets.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Mar 2017 21:43:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2edf446e20be1a26ff199b2ade6ce579d581f4f
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

f2edf44 by Guy Harris (guy@xxxxxxxxxxxx):

    Report an error for too-short packets.
    
    The packet length field gives the length of the *entire* packet, so, by
    definition, it must not be zero.  Make sure it's at least big enough for
    the packet header itself plus one segment header.
    
    Conflicts:
    	wiretap/stanag4607.c
    
    Bug: 13416
    Change-Id: I625bd5c0ce75ab1200b3becf12fc1c819fefcd63
    Reviewed-on: https://code.wireshark.org/review/20133
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c7042bedbb3b12c5f4e19e59e52da370d4ffe62f)
    Reviewed-on: https://code.wireshark.org/review/20135
    Reviewed-on: https://code.wireshark.org/review/20430
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  d62e7bf   DHCPv6: Avoid integer overflows.
    adds  f2edf44   Report an error for too-short packets.


Summary of changes:
 wiretap/stanag4607.c |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)