Wireshark-commits: [Wireshark-commits] master cfa5001: gsm_rr_csn_flag -> proto_tree_add_bits_item
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Mar 2017 11:29:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cfa50019b6366404f54da57700e50862aa87ebb0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cfa5001 by Michael Mann (mmann78@xxxxxxxxxxxx):

    gsm_rr_csn_flag -> proto_tree_add_bits_item when not using return value (CID-281350).
    
    When flags aren't used in flow control decisions, the function is
    effectively proto_tree_add_bits_item, so make it so.
    
    Change-Id: Ic82e734ddd24d41fe7c36e435cc941ed872c3b03
    Reviewed-on: https://code.wireshark.org/review/14773
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  daefa86   Fix issue with dissecting multiple DT1 packets in the frame
    adds  cfa5001   gsm_rr_csn_flag -> proto_tree_add_bits_item when not using return value (CID-281350).


Summary of changes:
 epan/dissectors/packet-gsm_a_rr.c |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)