Wireshark-commits: [Wireshark-commits] master bc94ffc: SIP: Add digest verification functionality
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Mar 2017 19:29:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc94ffcb0c754591e3dbac368f90e7f91d4a64bb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bc94ffc by erikdejong (erikdejong@xxxxxxxxx):

    SIP: Add digest verification functionality
    
    Added functionality to verify SIP authorization lines. With this functionality
    it's possible to find faulty passwords that were added to configuration by
    automatic processes (eg having unescaped '&' characters in XML config
    files) resulting in authorization failures that cannot be diagnosed
    otherwise.
    Other uses include bug hunting in SIP stacks.
    
    Bug: 13444
    Change-Id: I5abecd048480c8f5130a5112c531587c5993f12f
    Reviewed-on: https://code.wireshark.org/review/20314
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ca68749   IAX2: Add a timestamp check.
    adds  bc94ffc   SIP: Add digest verification functionality


Summary of changes:
 epan/dissectors/packet-sip.c |  263 ++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 254 insertions(+), 9 deletions(-)