Wireshark-commits: [Wireshark-commits] master f1c75cf: Rewrite dissectors to use Libgcrypt function
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Mar 2017 23:58:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1c75cf6ef7e9f9de1ec7fd798df941b972ec71c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f1c75cf by Erik de Jong (erikdejong@xxxxxxxxx):

    Rewrite dissectors to use Libgcrypt functions.
    
    As discussed on the mailinglist, rewriting dissectors to use Libgcrypt
    functions as Libgcrypt will be mandatory after change 20030.
    Removal of following functions:
    - crypt_md4
    - crypt_rc4*
    - aes_cmac_encrypt_*
    - md5_*
    - sha1_*
    - sha256_*
    
    Further candidates:
    - aes_*
    - rijndael_*
    - ...
    
    Added functions:
    - ws_hmac_buffer
    
    Added const macros:
    - HASH_MD5_LENGTH
    - HASH_SHA1_LENGTH
    
    Changes on epan/crypt/* verified with captures from
    https://wiki.wireshark.org/HowToDecrypt802.11
    Changes on packet-snmp.c and packet-radius.c verified with captures from
    https://wiki.wireshark.org/SampleCapture
    Changes on packet-tacacs.c verified with capture from
    http://ccie-in-3-months.blogspot.nl/2009/04/decoding-login-credentials-regardless.html
    
    Change-Id: Iea6ba2bf207cf0f1bf2117068fb1abcfeaafaa46
    Link: https://www.wireshark.org/lists/wireshark-dev/201702/msg00011.html
    Reviewed-on: https://code.wireshark.org/review/20095
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  4bd3c4d   Remove a cast that now causes rather than squelching warnings.
    adds  f1c75cf   Rewrite dissectors to use Libgcrypt functions.


Summary of changes:
 CMakeLists.txt                                     |    1 +
 Makefile.am                                        |    3 +-
 debian/libwsutil0.symbols                          |   25 +-
 editcap.c                                          |   14 +-
 epan/crypt/airpdcap.c                              |  166 ++++---
 epan/crypt/airpdcap_ccmp.c                         |   63 +--
 epan/crypt/airpdcap_rijndael.c                     |   19 +-
 epan/dissectors/asn1/cms/packet-cms-template.c     |   30 +-
 .../asn1/kerberos/packet-kerberos-template.c       |   28 +-
 epan/dissectors/asn1/snmp/packet-snmp-template.c   |   66 +--
 .../asn1/spnego/packet-spnego-template.c           |   85 ++--
 epan/dissectors/file-file.c                        |    1 -
 epan/dissectors/packet-3com-njack.c                |   28 +-
 epan/dissectors/packet-cms.c                       |   42 +-
 epan/dissectors/packet-corosync-totemnet.c         |   41 +-
 epan/dissectors/packet-data.c                      |   12 +-
 epan/dissectors/packet-dcerpc-netlogon.c           |  102 +++--
 epan/dissectors/packet-frame.c                     |   12 +-
 epan/dissectors/packet-kerberos.c                  |   40 +-
 epan/dissectors/packet-l2tp.c                      |   77 ++--
 epan/dissectors/packet-ntlmssp.c                   |  326 +++++++-------
 epan/dissectors/packet-radius.c                    |   53 ++-
 epan/dissectors/packet-sigcomp.c                   |   26 +-
 epan/dissectors/packet-snmp.c                      |   76 ++--
 epan/dissectors/packet-spnego.c                    |   89 ++--
 epan/dissectors/packet-tacacs.c                    |   26 +-
 epan/dissectors/packet-tcp.c                       |   13 +-
 wsutil/CMakeLists.txt                              |    6 +-
 wsutil/Makefile.am                                 |   11 +-
 wsutil/md4.c                                       |  185 --------
 wsutil/md4.h                                       |   29 --
 wsutil/md5.c                                       |  373 ----------------
 wsutil/md5.h                                       |   97 -----
 wsutil/rc4.c                                       |  112 -----
 wsutil/rc4.h                                       |   42 --
 wsutil/sha1.c                                      |  456 --------------------
 wsutil/sha1.h                                      |   69 ---
 wsutil/sha2.c                                      |  281 ------------
 wsutil/sha2.h                                      |   75 ----
 wsutil/{copyright_info.c => wsgcrypt.c}            |   36 +-
 wsutil/wsgcrypt.h                                  |   11 +
 41 files changed, 795 insertions(+), 2452 deletions(-)
 delete mode 100644 wsutil/md4.c
 delete mode 100644 wsutil/md4.h
 delete mode 100644 wsutil/md5.c
 delete mode 100644 wsutil/md5.h
 delete mode 100644 wsutil/rc4.c
 delete mode 100644 wsutil/rc4.h
 delete mode 100644 wsutil/sha1.c
 delete mode 100644 wsutil/sha1.h
 delete mode 100644 wsutil/sha2.c
 delete mode 100644 wsutil/sha2.h
 copy wsutil/{copyright_info.c => wsgcrypt.c} (61%)