Wireshark-commits: [Wireshark-commits] master-2.2 fee76b0: IEEE 802.11: Handle Atheros padding
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Mar 2017 09:19:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fee76b0e605b22db994aa593bc96e6a5b457181b
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

fee76b0 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    IEEE 802.11: Handle Atheros padding
    
    For some unknown reason between 802.11 protocol fields end and LLC
    protocol field start two octets of padding may appear. These octets
    (value 0x00) were observed on the OLPC laptop, heuristically detected
    and marked as OLPC mysterious stuff.
    
    It seems that Atheros chipset drivers also show this behaviour,
    although the padding is not 0x0000, but seem to be a duplicate of the
    sequence control field. This is now also heuristically detected and
    marked more generically as payload padding.
    
    Bug: 13411
    Change-Id: I1e817e07dc19be8b3917ff302ede3328ca6a4938
    Reviewed-on: https://code.wireshark.org/review/20284
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    (cherry picked from commit 311b1ee70072531352262f3a47181e89472e3109)
    Reviewed-on: https://code.wireshark.org/review/20308
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  d00ced1   Do more record length checks.
    adds  fee76b0   IEEE 802.11: Handle Atheros padding


Summary of changes:
 epan/dissectors/packet-ieee80211.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)