Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 7eb76d2: Don't go past the end of a page in a NetScaler file.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7eb76d2975de12127c8ad9bac16a88179a7fa465
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7eb76d2 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't go past the end of a page in a NetScaler file.
    
    Records in a properly formatted NetScaler file shouldn't go past the end
    of a page, but nothing guarantees that a NetScaler file will be properly
    formatted.
    
    NetScaler 3.x files allow record bodies to go past the end of a page,
    but 1.x and 2.x files don't, so treat record headers that go past the
    end of a page, and record bodies in 1.x and 2.x files that go past the
    end of a page, as errors.
    
    Clean up some stuff while we're at it.
    
    Bug: 13430
    Change-Id: I3b1d56086e3bb14b246406f306e3d730df337561
    Reviewed-on: https://code.wireshark.org/review/20326
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 19c51d27b9cabf7b811d6c60e42a59330235c2de)
    Reviewed-on: https://code.wireshark.org/review/20327
    

Actions performed:

    from  ddf4814   Get rid of an unnecessary variable.
    adds  7eb76d2   Don't go past the end of a page in a NetScaler file.


Summary of changes:
 wiretap/netscaler.c |   85 +++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 69 insertions(+), 16 deletions(-)