Wireshark-commits: [Wireshark-commits] master-2.2 8a168ed: androiddump: Use nonblocking connect
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 1 Mar 2017 06:40:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a168ed1b3b7af79b31e2cc2c746dae395dd8847
Submitter: Michal Labedzki (michal.tomasz.labedzki@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8a168ed by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    androiddump: Use nonblocking connect
    
    Release as version 1.0.3 [backport]:
    All connects to ADB are now non-blocking.
    Try to connect up to 10 times with 1ms delays,
    so in worst-case it takes ~10ms (for example 14ms)
    
    Use non-blocking socket for a while on Windows.
    
    Bug: 13104
    Change-Id: I791909c9c951b62195b48acd82490e1b9ebf2be0
    Reviewed-on: https://code.wireshark.org/review/19968
    Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@xxxxxxxxx>
    Tested-by: Michal Labedzki <michal.tomasz.labedzki@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/20263
    

Actions performed:

    from  991f1b5   Return correct filter for get_hostlist_filter()
    adds  8a168ed   androiddump: Use nonblocking connect


Summary of changes:
 extcap/androiddump.c |   77 ++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 68 insertions(+), 9 deletions(-)