Wireshark-commits: [Wireshark-commits] master 147d0c2: androiddump: Use nonblocking connect
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Feb 2017 13:58:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=147d0c2e36822afa17df686d8634b7918614a80a
Submitter: Michal Labedzki (michal.tomasz.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

147d0c2 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    androiddump: Use nonblocking connect
    
    Release as version 1.0.5:
    All connects to ADB are now non-blocking.
    Try to connect up to 10 times with 1ms delays,
    so in worst-case it takes ~10ms (for example 14ms)
    
    Bug: 13104
    Change-Id: I791909c9c951b62195b48acd82490e1b9ebf2be0
    Reviewed-on: https://code.wireshark.org/review/19968
    Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@xxxxxxxxx>
    Tested-by: Michal Labedzki <michal.tomasz.labedzki@xxxxxxxxx>
    

Actions performed:

    from  f22c713   tools: add options validation.
    adds  147d0c2   androiddump: Use nonblocking connect


Summary of changes:
 extcap/androiddump.c |   68 ++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 61 insertions(+), 7 deletions(-)