Wireshark-commits: [Wireshark-commits] master cecf9f1: TLS13: update NewSessionTicket dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Feb 2017 18:49:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cecf9f13fe4aa283bba131e53ae2c84a4a68ccfb
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cecf9f1 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS13: update NewSessionTicket dissection
    
    The new ticket_age_add field resulted in a dissector exception. With
    this fixed, the tls13-18-picotls-earlydata.pcap capture can now be fully
    decrypted.
    
    Also add validation for the ticket length (using ssl_add_vector).
    
    Change-Id: I167038f682b47b2d1da020a8f241daaf7af22017
    Ping-Bug: 12779
    Reviewed-on: https://code.wireshark.org/review/19992
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f958dd5   TLS13: support Early Data and accept CLIENT_EARLY_TRAFFIC_SECRET
    adds  cecf9f1   TLS13: update NewSessionTicket dissection


Summary of changes:
 epan/dissectors/packet-dtls.c      |    4 +--
 epan/dissectors/packet-ssl-utils.c |   60 ++++++++++++++++++++++++++++--------
 epan/dissectors/packet-ssl-utils.h |   15 ++++++---
 epan/dissectors/packet-ssl.c       |    4 +--
 4 files changed, 62 insertions(+), 21 deletions(-)