Wireshark · Wireshark-commits: [Wireshark-commits] master 7893ffa: wsutil/sober128: remove unused macros and functions

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7893ffa478bdbd4cd48aa438569a0bd32fada99b
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7893ffa by Peter Wu (peter@xxxxxxxxxxxxx):

    wsutil/sober128: remove unused macros and functions
    
    Removed unused macros/functions that are apparently imported from
    LibTomCrypt, only LOAD32L and STORE32L are needed. Remove code that
    tries to distinguish between little/big endian, since WORDS_BIGENDIAN
    was never defined, this would never have worked on big endian anyway.
    
    Remove the special ROR "optimization" for GCC on i386, modern compilers
    are able to optimize it to exactly the same thing. The generic
    LOAD32L/STORE32L macros are less optimized (as can be seen in the
    generated code), but this was not noticable in the mean running time.
    
    Tested with the packet capture from bug 3232, the result is the same:
    
        tshark -ocorosync_totemnet.private_keys:example.com -r corosync-totemsrp--key:example.com--2nodes.pcap -Vx
    
    Bug: 13368
    Change-Id: I59bf27d7dd990bbcd5ad34a1797f4a6c8a04512d
    Reviewed-on: https://code.wireshark.org/review/19894
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f15d5dd   xml: use wmem allocators and replace GHashTable with wmem_map_t.
    adds  7893ffa   wsutil/sober128: remove unused macros and functions


Summary of changes:
 wsutil/sober128.c |  429 +----------------------------------------------------
 wsutil/sober128.h |    4 +-
 2 files changed, 4 insertions(+), 429 deletions(-)