Wireshark-commits: [Wireshark-commits] master 7740425: (D)TLS: consolidate and simplify decrypted r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Jan 2017 03:44:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77404250d53a4b123f05c834108e231a8885305a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7740425 by Peter Wu (peter@xxxxxxxxxxxxx):

    (D)TLS: consolidate and simplify decrypted records handling
    
    Previously there was a distinction between decrypted handshake
    Application Data records ("Decrypted SSL data") and some others (like
    Alerts, Handshake and Heartbeat, "Decrypted SSL record"). Remove this
    distinction and always decrypt the payload before passing it on and
    always display a data sources for decrypted contents ("Decrypted SSL").
    
    This is prepatory work for TLS 1.3 support where the content type is
    located in the encrypted record, having the record decryption in one
    place makes it easier to adapt.
    
    Change-Id: I92c51c7f9e87e5c93231d28c39a8e896f5afd1ef
    Ping-Bug: 12779
    Reviewed-on: https://code.wireshark.org/review/19789
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  990b5dc   Qt: Add exported packet files to the recent files
    adds  7740425   (D)TLS: consolidate and simplify decrypted records handling


Summary of changes:
 epan/dissectors/packet-dtls.c      |  118 ++++++++++-----------------
 epan/dissectors/packet-ssl-utils.c |  107 ++++++++----------------
 epan/dissectors/packet-ssl-utils.h |   33 +++-----
 epan/dissectors/packet-ssl.c       |  158 +++++++++++++++---------------------
 4 files changed, 157 insertions(+), 259 deletions(-)