Wireshark-commits: [Wireshark-commits] master 87f4dc0: Qt: Preference editor improvements.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87f4dc0a9d22060d379db2daa3f4271137a4edcc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
87f4dc0 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):
Qt: Preference editor improvements.
Use correct disconnect() signature to ensure everything is disconnected
before connecting new signals. Without this all previous connects() are
still active. This leads to gradually more and more syntax checks being
called for each change, and possibility of a wrong syntax check
(especially for strings which has no syntax check).
Use the textEdited() signal to trigger a syntax check at startup.
This gives consistency.
Do not clear preferenceLineEdit when done because it looks weird when
the preference text disappears while the widget is hiding. The entry
is cleared before next show anyway.
Change-Id: I21c6fd8ec6bb0ecff1b2c0b66fe97dc3eaecf9b3
Reviewed-on: https://code.wireshark.org/review/19788
Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from dc86242 ssl-utils: recognize new TLS 1.3 keylog format
adds 87f4dc0 Qt: Preference editor improvements.
Summary of changes:
ui/qt/preference_editor_frame.cpp | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
