Wireshark-commits: [Wireshark-commits] master 7722003: DNS: use formatted text in add_rr_to_tree()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Jan 2017 08:14:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7722003908ade4d36365c0a11e8a37895edfc066
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7722003 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    DNS: use formatted text in add_rr_to_tree() and add_opt_rr_to_tree
    
    Since the fix for bug 13289, an empty string can be returned by get_dns_name.
    Ensure that:
    - a malformed encoding with no characters and a length > 1 triggers an exception
    - the formatted version is used to add info in tree.
    
    Bug: 13339
    Change-Id: I88125a351904eabb5cededfbfe1d5ef14ea61ecc
    Reviewed-on: https://code.wireshark.org/review/19714
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0212739   One more cf_merge_files_to_tempfile() call needed to be changed.
    adds  7722003   DNS: use formatted text in add_rr_to_tree() and add_opt_rr_to_tree


Summary of changes:
 epan/dissectors/packet-dns.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)