Wireshark-commits: [Wireshark-commits] master 97b3f75: iso14443: use proto_tree_add_checksum()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Jan 2017 05:39:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97b3f75c0fc2e1f46f7a4511acdec9e433b4ce16
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

97b3f75 by Martin Kaiser (wireshark@xxxxxxxxx):

    iso14443: use proto_tree_add_checksum()
    
    replace our own function for dissecting the CRC with
    the generic proto_tree_add_checksum()
    
    Change-Id: I569c877836a7b771b01a37b57b6c50fc0183e9a7
    Reviewed-on: https://code.wireshark.org/review/19601
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ebd1989   Qt: check NULL before dereference (CID 1394324)
    adds  97b3f75   iso14443: use proto_tree_add_checksum()


Summary of changes:
 epan/dissectors/packet-iso14443.c |  126 ++++++++++++++++++++++---------------
 1 file changed, 76 insertions(+), 50 deletions(-)