Wireshark-commits: [Wireshark-commits] master-2.2 c413cdd: Comments on the first nibble stuff.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 8 Jan 2017 02:35:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c413cdd2854afde000ac3b5ef1189b288ceaccc7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c413cdd by Guy Harris (guy@xxxxxxxxxxxx):

    Comments on the first nibble stuff.
    
    If you don't have control words - and several MPLS pseudo-wire RFCs say
    "in these cases, a control word isn't necessary, and isn't useful, so
    you might want to leave it out" - the first nibble values of 0, 1, 4,
    and 6 could just be part of the packet header.
    
    Explain some other stuff as well.
    
    Change-Id: I2f1aae2ab8653bdd7f8b3b52ef450f6d43a1afcd
    Reviewed-on: https://code.wireshark.org/review/19583
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 082ba063efd2a7faf6bd25d73b08197708e117b8)
    Reviewed-on: https://code.wireshark.org/review/19584
    

Actions performed:

    from  4759c5b   Make column size sanity check more sensible.
    adds  c413cdd   Comments on the first nibble stuff.


Summary of changes:
 epan/dissectors/packet-mpls.c |   45 ++++++++++++++++++++++++++++++++++++++---
 1 file changed, 42 insertions(+), 3 deletions(-)