Wireshark-commits: [Wireshark-commits] master 2009dcc: extcap: fix memleak via data_file_url
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Jan 2017 20:33:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2009dcc98dc46712c8b64ae30408c4d53c64980b
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2009dcc by Peter Wu (peter@xxxxxxxxxxxxx):

    extcap: fix memleak via data_file_url
    
    Commit v2.1.0rc0-2181-ga4e2263ac4 introduced a helppage parameter, but
    all callers were NULL. In a later change, callers would use the
    data_file_url() function, but this needs to be freed, so do that.
    
    Fixes: v2.3.0rc0-1825-ge5596b74bd ("extcap: set help page for all extcaps.")
    Change-Id: I967c0f8c6b50d9e78ac227575de24a81f97d376a
    Reviewed-on: https://code.wireshark.org/review/19570
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  03a8884   Add MUD-URL manufacturer usage description certificate extension.
    adds  2009dcc   extcap: fix memleak via data_file_url


Summary of changes:
 extcap/androiddump.c |    5 ++++-
 extcap/ciscodump.c   |    5 ++++-
 extcap/randpktdump.c |    5 ++++-
 extcap/sshdump.c     |    5 ++++-
 extcap/udpdump.c     |    5 ++++-
 5 files changed, 20 insertions(+), 5 deletions(-)