Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 9168356: Make column size sanity check more sensible.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9168356d6107ec5e85cc83532e61358f077e2796
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9168356 by Noel Power (noel.power@xxxxxxxx):

    Make column size sanity check more sensible.
    
    The existing sanity check on column_size makes incorrect assumptions
    about the size of the CTableColumn structure (which is an internal
    dissector structure that contains optional data). The sanity check
    test *always* fails. This change uses the minimum size of CTableColumn
    structure instead which should prevent excessive allocation during fuzz
    testing.
    
    Bug: 13299
    Change-Id: Id9fcbc15a4df4c74bb7576c6fdca1000890947fd
    Signed-off-by: Noel Power <noel.power@xxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19566
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 0dcbfab4265b4f494a7b162d2c34c99ed7994541)
    Reviewed-on: https://code.wireshark.org/review/19574
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 4759c5b785cdcff66096fa4ed1c56b572505fc61)
    Reviewed-on: https://code.wireshark.org/review/19575
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fda5315   QUIC: fix typo on ACK num revived field description
    adds  9168356   Make column size sanity check more sensible.


Summary of changes:
 epan/dissectors/packet-mswsp.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)