Wireshark-commits: [Wireshark-commits] master 6a6d7ea: Convert range API to always use wmem memory.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Jan 2017 00:44:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a6d7ea34f43515dfe3f52aa96b943c272c925a7 Submitter: Michael Mann (mmann78@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 6a6d7ea by Michael Mann (mmann78@xxxxxxxxxxxx): Convert range API to always use wmem memory. This is mostly to address memory leaks in range preferences (the biggest user of range functionality) on shutdown. Now range preferences must use epan scoped memory when referencing internal preference structures to keep consistency. Change-Id: Idc644f59b5b42fa1d46891542b53ff13ea754157 Reviewed-on: https://code.wireshark.org/review/19387 Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx> Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Actions performed: from 29a7fce 802.11(ad): Enhance dissection of Beacon Interval Control (BIC) adds 6a6d7ea Convert range API to always use wmem memory. Summary of changes: epan/addr_resolv.c | 5 ++- epan/decode_as.c | 2 +- .../asn1/ansi_map/packet-ansi_map-template.c | 6 +-- epan/dissectors/asn1/camel/packet-camel-template.c | 6 +-- .../asn1/gsm_map/packet-gsm_map-template.c | 6 +-- epan/dissectors/asn1/inap/packet-inap-template.c | 6 +-- epan/dissectors/asn1/pcap/packet-pcap-template.c | 6 +-- epan/dissectors/asn1/tcap/packet-tcap-template.c | 6 +-- epan/dissectors/packet-ansi_map.c | 6 +-- epan/dissectors/packet-camel.c | 6 +-- epan/dissectors/packet-diameter.c | 6 +-- epan/dissectors/packet-gopher.c | 1 - epan/dissectors/packet-gsm_map.c | 6 +-- epan/dissectors/packet-h264.c | 4 +- epan/dissectors/packet-http.c | 15 +++---- epan/dissectors/packet-igmp.c | 4 +- epan/dissectors/packet-inap.c | 6 +-- epan/dissectors/packet-iscsi.c | 2 +- epan/dissectors/packet-iser.c | 2 +- epan/dissectors/packet-kafka.c | 1 - epan/dissectors/packet-netflow.c | 12 +++--- epan/dissectors/packet-nvme-rdma.c | 2 +- epan/dissectors/packet-opa-fe.c | 7 ++-- epan/dissectors/packet-opa-mad.c | 10 ++--- epan/dissectors/packet-pcap.c | 6 +-- epan/dissectors/packet-sccp.c | 13 +++--- epan/dissectors/packet-sgsap.c | 6 +-- epan/dissectors/packet-tcap.c | 6 +-- epan/dissectors/packet-tds.c | 1 - epan/dissectors/packet-tftp.c | 1 - epan/dissectors/packet-tpkt.c | 9 ++-- epan/dissectors/packet-uaudp.c | 1 - epan/dissectors/packet-vnc.c | 1 - epan/dissectors/packet-vp8.c | 4 +- epan/dissectors/packet-xml.c | 6 --- epan/packet.c | 5 +-- epan/packet_range.c | 6 +-- epan/prefs.c | 26 ++++++------ epan/prefs.h | 2 +- epan/range.c | 43 ++++++++++---------- epan/range.h | 18 ++++---- epan/uat.c | 3 +- epan/uat.h | 2 +- epan/wslua/wslua_dissector.c | 18 ++++---- epan/wslua/wslua_pref.c | 2 +- plugins/stats_tree/pinfo_stats_tree.c | 4 +- plugins/transum/packet-transum.c | 17 +------- ui/gtk/decode_as_dlg.c | 4 +- ui/gtk/prefs_dlg.c | 11 ++--- ui/preference_utils.c | 18 ++++---- ui/qt/decode_as_dialog.cpp | 4 +- ui/qt/module_preferences_scroll_area.cpp | 4 +- ui/qt/preference_editor_frame.cpp | 14 +++---- ui/qt/preferences_dialog.cpp | 8 ++-- 54 files changed, 189 insertions(+), 207 deletions(-)
- Prev by Date: [Wireshark-commits] master 29a7fce: 802.11(ad): Enhance dissection of Beacon Interval Control (BIC)
- Next by Date: [Wireshark-commits] master 4dc983d: packet: fix memleak of "short_name" for heuristics dissectors
- Previous by thread: [Wireshark-commits] master 29a7fce: 802.11(ad): Enhance dissection of Beacon Interval Control (BIC)
- Next by thread: [Wireshark-commits] master 4dc983d: packet: fix memleak of "short_name" for heuristics dissectors
- Index(es):