Wireshark-commits: [Wireshark-commits] master 3fae136: Qt: add SACK graphs to tcptrace graph
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 Jan 2017 05:25:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3fae1366d1041c3591a919ce91aed27f983715a9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3fae136 by Kevin Hogan (kwabena@xxxxxxxxxx):

    Qt: add SACK graphs to tcptrace graph
    
    Primarily, this adds visual indication of SACK blocks to tcptrace.
    In addition:
     - cleaned up focus behavior for graph selector and spinboxes
     - added time-delay update to streamNumber spinBox
        (similar to behavior of maWindow spinBox)
     - changed ACK selection to select only SACKed responses
        (rather than all ACKs - SACKs seemed more useful to look at)
    
    Change-Id: I47d9e98d54f14e4955008ecea791b77f805c8ba9
    Reviewed-on: https://code.wireshark.org/review/19388
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  15ad25e   RTPS: Added dissection for Parametrized user data
    adds  3fae136   Qt: add SACK graphs to tcptrace graph


Summary of changes:
 ui/qt/tcp_stream_dialog.cpp |  194 +++++++++++++++++++++++++++++++------------
 ui/qt/tcp_stream_dialog.h   |   24 +++++-
 ui/qt/tcp_stream_dialog.ui  |   24 +++++-
 3 files changed, 185 insertions(+), 57 deletions(-)