Wireshark-commits: [Wireshark-commits] master f4b0abc: Dissectors don't need a journey of self disc
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 31 Dec 2016 07:32:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4b0abc7296bbb431e64e31f85b24c29196c2ae4 Submitter: Anders Broman (a.broman58@xxxxxxxxx) Changed: branch: master Repository: wireshark Commits: f4b0abc by Michael Mann (mmann78@xxxxxxxxxxxx): Dissectors don't need a journey of self discovery. They already know who they are when they register themselves. Saving the handle then to avoid finding it later. Not sure if this will increase unnecessary register_dissector functions (instead of using create_dissector_handle in proto_reg_handoff function) when other dissectors copy/paste, but it should make startup time a few microseconds better. Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43 Reviewed-on: https://code.wireshark.org/review/19481 Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx> Actions performed: from 1396459 Add BASE_NO_DISPLAY_VALUE to allow field value to not be shown. adds f4b0abc Dissectors don't need a journey of self discovery. Summary of changes: epan/dissectors/asn1/dop/packet-dop-template.c | 6 +- epan/dissectors/asn1/h225/packet-h225-template.c | 2 +- .../asn1/lte-rrc/packet-lte-rrc-template.c | 6 +- epan/dissectors/asn1/rtse/packet-rtse-template.c | 6 +- epan/dissectors/packet-3g-a11.c | 7 +- epan/dissectors/packet-alcap.c | 6 +- epan/dissectors/packet-amqp.c | 7 +- epan/dissectors/packet-armagetronad.c | 13 +- epan/dissectors/packet-assa_r3.c | 6 +- epan/dissectors/packet-ayiya.c | 7 +- epan/dissectors/packet-bacnet.c | 7 +- epan/dissectors/packet-bfd.c | 7 +- epan/dissectors/packet-bittorrent.c | 3 +- epan/dissectors/packet-bpdu.c | 14 +- epan/dissectors/packet-bvlc.c | 6 +- epan/dissectors/packet-bzr.c | 6 +- epan/dissectors/packet-catapult-dct2000.c | 5 +- epan/dissectors/packet-ccsds.c | 7 +- epan/dissectors/packet-chdlc.c | 6 +- epan/dissectors/packet-cimetrics.c | 9 +- epan/dissectors/packet-coap.c | 7 +- epan/dissectors/packet-cops.c | 7 +- epan/dissectors/packet-db-lsp.c | 13 +- epan/dissectors/packet-diameter.c | 3 +- epan/dissectors/packet-dof.c | 9 +- epan/dissectors/packet-dop.c | 14 +- epan/dissectors/packet-dpnss-link.c | 7 +- epan/dissectors/packet-dtls.c | 5 +- epan/dissectors/packet-dua.c | 6 +- epan/dissectors/packet-dvb-nit.c | 7 +- epan/dissectors/packet-ecp-oui.c | 7 +- epan/dissectors/packet-ehs.c | 7 +- epan/dissectors/packet-enip.c | 11 +- epan/dissectors/packet-epmd.c | 7 +- epan/dissectors/packet-esis.c | 7 +- epan/dissectors/packet-eth.c | 11 +- epan/dissectors/packet-etherip.c | 7 +- epan/dissectors/packet-exported_pdu.c | 6 +- epan/dissectors/packet-fr.c | 6 +- epan/dissectors/packet-ftp.c | 9 +- epan/dissectors/packet-gmr1_dtap.c | 6 +- epan/dissectors/packet-gprs-llc.c | 6 +- epan/dissectors/packet-gsm_a_bssmap.c | 6 +- epan/dissectors/packet-gsm_a_dtap.c | 6 +- epan/dissectors/packet-gsm_bssmap_le.c | 7 +- epan/dissectors/packet-gsm_sim.c | 5 +- epan/dissectors/packet-gssapi.c | 7 +- epan/dissectors/packet-gtp.c | 8 +- epan/dissectors/packet-gvcp.c | 12 +- epan/dissectors/packet-h223.c | 4 +- epan/dissectors/packet-h225.c | 2 +- epan/dissectors/packet-h263p.c | 7 +- epan/dissectors/packet-h264.c | 6 +- epan/dissectors/packet-hpsw.c | 8 +- epan/dissectors/packet-hpteam.c | 7 +- epan/dissectors/packet-hyperscsi.c | 7 +- epan/dissectors/packet-iax2.c | 6 +- epan/dissectors/packet-icmp.c | 6 +- epan/dissectors/packet-ieee80211.c | 9 +- epan/dissectors/packet-ieee802154.c | 15 +- epan/dissectors/packet-interlink.c | 6 +- epan/dissectors/packet-ip.c | 5 +- epan/dissectors/packet-ipos.c | 3 +- epan/dissectors/packet-ipv6.c | 5 +- epan/dissectors/packet-ipx.c | 12 +- epan/dissectors/packet-isakmp.c | 7 +- epan/dissectors/packet-iso7816.c | 8 +- epan/dissectors/packet-iua.c | 6 +- epan/dissectors/packet-iuup.c | 6 +- epan/dissectors/packet-jmirror.c | 6 +- epan/dissectors/packet-jxta.c | 11 +- epan/dissectors/packet-k12.c | 3 +- epan/dissectors/packet-kerberos4.c | 7 +- epan/dissectors/packet-lapb.c | 6 +- epan/dissectors/packet-llc.c | 6 +- epan/dissectors/packet-lte-rrc.c | 20 +- epan/dissectors/packet-lwm.c | 6 +- epan/dissectors/packet-m2pa.c | 5 +- epan/dissectors/packet-m3ua.c | 5 +- epan/dissectors/packet-mbim.c | 4 +- epan/dissectors/packet-megaco.c | 3 +- epan/dissectors/packet-mime-encap.c | 7 +- epan/dissectors/packet-miop.c | 7 +- epan/dissectors/packet-mip.c | 7 +- epan/dissectors/packet-mp4ves.c | 8 +- epan/dissectors/packet-mpeg-pmt.c | 8 +- epan/dissectors/packet-mpls-y1711.c | 3 +- epan/dissectors/packet-mpls.c | 7 +- epan/dissectors/packet-ms-mms.c | 3 +- epan/dissectors/packet-msrp.c | 3 +- epan/dissectors/packet-mstp.c | 6 +- epan/dissectors/packet-mtp3mg.c | 8 +- epan/dissectors/packet-ndp.c | 7 +- epan/dissectors/packet-negoex.c | 7 +- epan/dissectors/packet-newmail.c | 7 +- ... 115 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 1396459: Add BASE_NO_DISPLAY_VALUE to allow field value to not be shown.
- Next by Date: [Wireshark-commits] master 6a5fcc5: TLS(1.3): Add PSK Key Exchanges Modes (45) hello extension
- Previous by thread: [Wireshark-commits] master 1396459: Add BASE_NO_DISPLAY_VALUE to allow field value to not be shown.
- Next by thread: [Wireshark-commits] master 6a5fcc5: TLS(1.3): Add PSK Key Exchanges Modes (45) hello extension
- Index(es):