Wireshark-commits: [Wireshark-commits] master 0c4d074: extcap_options_dialog: fix compilation with
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Dec 2016 13:54:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0c4d074f2835711c10b41ca72c507c03b4c9cc55
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0c4d074 by Martin Kaiser (wireshark@xxxxxxxxx):

    extcap_options_dialog: fix compilation with Qt4
    
    Qt4's QFileInfo::exist() can only be used with an existing QFileInfo
    object. The version that accepts the file name as paramter was
    introduced in Qt5.
    
    Create a temporary QFileInfo object and call exists() on this object.
    
    Change-Id: I162cc22ecba61b2c2f16f9f0916b0db7969abb51
    Reviewed-on: https://code.wireshark.org/review/19408
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  55549f5   zvt: len is used in dissect_zvt_int_status()
    adds  0c4d074   extcap_options_dialog: fix compilation with Qt4


Summary of changes:
 ui/qt/extcap_options_dialog.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)