Wireshark-commits: [Wireshark-commits] master-2.2 5c5156b: Don't use PCAP_ERROR if it's not known t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Dec 2016 18:57:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c5156b45ed50cd791df567b0132fc13092d0c1c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5c5156b by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use PCAP_ERROR if it's not known to be defined.
    
    The introduction of pcap_list_datalinks() predates the introduction of
    PCAP_ERROR, so the presence of pcap_list_datalinks() doesn't guarantee
    that PCAP_ERROR is defined.  Change the use of PCAP_ERROR when checking
    the result of pcap_list_datalinks() to just check for -1.
    
    Change-Id: Id8229b7aebd02eaf3701983f9343503397af4fb3
    Reviewed-on: https://code.wireshark.org/review/19351
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 23d80b00122984535e47e5e2af8cbd4deb9b8a9e)
    Reviewed-on: https://code.wireshark.org/review/19352
    

Actions performed:

    from  10aa8e9   [SMTP] Bugfix BDAT command handling
    adds  5c5156b   Don't use PCAP_ERROR if it's not known to be defined.


Summary of changes:
 caputils/capture-pcap-util.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)