Wireshark-commits: [Wireshark-commits] master 2612f23: Lua: Fix some memory leaks in error paths.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Dec 2016 20:11:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2612f23ad2664690c62b6e17db465945b51b938c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2612f23 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Lua: Fix some memory leaks in error paths.
    
    Because luaL_argerror() does a longjmp all memory free must be done
    before calling this.
    
    Also rewrote true_false_string_from_table() to be a bit simpler
    and to give argument error when too many strings in the table.
    
    Change-Id: Ied0fa468f1274155c746fe2e086dacf1a8582b08
    Reviewed-on: https://code.wireshark.org/review/19325
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7d1b8de   Call Flow: Fix - Duration of segment of RTP flow is wrong in call flow.
    adds  2612f23   Lua: Fix some memory leaks in error paths.


Summary of changes:
 epan/wslua/wslua_proto_field.c |   94 +++++++++++++++++++++++++---------------
 1 file changed, 60 insertions(+), 34 deletions(-)