Wireshark-commits: [Wireshark-commits] master 53f2b37: CIP: Always handle extra data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Dec 2016 14:28:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=53f2b3710e9b661410dbee248fd4494741d18574
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

53f2b37 by D. Ulis (daulis0@xxxxxxxxx):

    CIP: Always handle extra data
    
    1. Generically handle/display all unparsed data. Any unparsed data can be found with cip.data
    2. This now shows at least some unparsed data that was not previously displayed. Previously, extra data sent with Get Attribute List requests was not displayed. It was difficult to tell why devices were returning errors, without knowing there was extra data.
    3. Make most functions return the number of bytes processed to support the above points.
    
    Change-Id: I290c09d76e74c18facaef99c8903e7937fbdd710
    Reviewed-on: https://code.wireshark.org/review/19263
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  12fd99f   [BOOTP/DHCPv6] Add new manufacturer usage description (MUD) DHCP option, which presents a URL.
    adds  53f2b37   CIP: Always handle extra data


Summary of changes:
 epan/dissectors/packet-cip.c |  287 +++++++++++++-----------------------------
 epan/dissectors/packet-cip.h |    2 +-
 2 files changed, 91 insertions(+), 198 deletions(-)