Wireshark-commits: [Wireshark-commits] master 232cb9a: Remove proto_item_append_text calls in favor
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Dec 2016 03:04:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=232cb9a2dd87ea9cc9c88d4c32bfb7b452705130
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

232cb9a by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.
    
    Many proto_item_append_text calls were just adding a unit string to a field.
    There's a better way to do that now.
    
    Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78
    Reviewed-on: https://code.wireshark.org/review/19289
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8efb7fe   Adjust proto_tree_add_xxx_format_value calls to use unit string
    adds  232cb9a   Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.


Summary of changes:
 debian/libwireshark0.symbols          |    8 +++
 epan/dissectors/packet-asap.c         |    6 +-
 epan/dissectors/packet-btavdtp.c      |   18 ++---
 epan/dissectors/packet-bthci_cmd.c    |    6 +-
 epan/dissectors/packet-bthci_evt.c    |   16 ++---
 epan/dissectors/packet-bthfp.c        |    8 +--
 epan/dissectors/packet-bthsp.c        |    8 +--
 epan/dissectors/packet-btl2cap.c      |    5 +-
 epan/dissectors/packet-btle.c         |   10 ++-
 epan/dissectors/packet-btmcap.c       |   30 ++++-----
 epan/dissectors/packet-enrp.c         |    6 +-
 epan/dissectors/packet-gsm_a_common.c |   22 +++---
 epan/dissectors/packet-gsm_a_gm.c     |   17 +++--
 epan/dissectors/packet-gtp.c          |   43 +++++-------
 epan/dissectors/packet-gvcp.c         |    6 +-
 epan/dissectors/packet-ieee1722.c     |   10 ++-
 epan/dissectors/packet-ieee802154.c   |    5 +-
 epan/dissectors/packet-ipsec.c        |    7 +-
 epan/dissectors/packet-ipv6.c         |   15 ++---
 epan/dissectors/packet-ismacryp.c     |    5 +-
 epan/dissectors/packet-knxnetip.c     |   77 +++++++--------------
 epan/dissectors/packet-lldp.c         |   53 +++++++--------
 epan/dissectors/packet-mbim.c         |  119 ++++++++++++---------------------
 epan/dissectors/packet-oampdu.c       |   20 +++---
 epan/dissectors/packet-ppi-vector.c   |   89 +++++++-----------------
 epan/dissectors/packet-rftap.c        |   36 ++++------
 epan/dissectors/packet-sbc.c          |   24 +++----
 epan/dissectors/packet-simulcrypt.c   |   68 +++++++------------
 epan/dissectors/packet-spice.c        |   11 ++-
 epan/dissectors/packet-sync.c         |    5 +-
 epan/dissectors/packet-usb-ccid.c     |   10 ++-
 epan/dissectors/packet-usb-com.c      |   14 ++--
 epan/dissectors/packet-xip-serval.c   |    8 +--
 epan/unit_strings.c                   |    8 +++
 epan/unit_strings.h                   |    8 +++
 plugins/wimax/msg_dcd.c               |   73 +++++++++-----------
 plugins/wimax/msg_rng_rsp.c           |   10 ++-
 plugins/wimax/msg_ucd.c               |   79 +++++++++-------------
 plugins/wimax/wimax_utils.c           |   57 ++++++++--------
 plugins/wimax/wimax_utils.h           |   12 ++++
 40 files changed, 418 insertions(+), 614 deletions(-)